Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

other: if in a non-D0 state, short-circuit further logic #1355

Merged
merged 5 commits into from
Dec 20, 2023

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Dec 11, 2023

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

SC immediately if a non-D0 state is encountered while grabbing temp data in Linux.

Issue

If applicable, what issue does this address?

Maybe affects #1291?

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 42 lines in your changes are missing coverage. Please review.

Comparison is base (004c837) 32.09% compared to head (f4aca85) 32.33%.

Files Patch % Lines
src/app/data_harvester/temperature/linux.rs 6.06% 31 Missing ⚠️
src/widgets/temperature_table.rs 0.00% 8 Missing ⚠️
src/app/data_harvester/nvidia.rs 0.00% 1 Missing ⚠️
src/app/data_harvester/temperature/sysinfo.rs 0.00% 1 Missing ⚠️
src/data_conversion.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1355      +/-   ##
==========================================
+ Coverage   32.09%   32.33%   +0.23%     
==========================================
  Files          98       98              
  Lines       17113    17141      +28     
==========================================
+ Hits         5492     5542      +50     
+ Misses      11621    11599      -22     
Flag Coverage Δ
macos-12 34.16% <64.51%> (+0.28%) ⬆️
ubuntu-latest 33.92% <34.92%> (+0.24%) ⬆️
windows-2019 34.21% <64.51%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClementTsang ClementTsang marked this pull request as ready for review December 20, 2023 04:52
@ClementTsang ClementTsang merged commit a67da93 into main Dec 20, 2023
33 checks passed
@ClementTsang ClementTsang deleted the pull_out_temp_check branch December 20, 2023 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant